dmvk commented on a change in pull request #10175: [FLINK-14746][web] Handle
uncaught exceptions in HistoryServerArchive…
URL: https://github.com/apache/flink/pull/10175#discussion_r347891464
##########
File path:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
##########
@@ -127,7 +129,10 @@ public ArchiveEventType getType() {
}
void start() {
- executor.scheduleWithFixedDelay(fetcherTask, 0,
refreshIntervalMillis, TimeUnit.MILLISECONDS);
+ final Runnable guardedTask =
Runnables.withUncaughtExceptionHandler(
+ fetcherTask, FatalExitExceptionHandler.INSTANCE);
Review comment:
Not really, in our case we were swallowing OOMs, which leads to undefined
state. History server code handles all exceptions, so this will be used only in
case Error is thrown (bailing out is the most reasonable option here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
