TisonKun commented on a change in pull request #10251:
[FLINK-14851][FLINK-14850] Implement Executors and wire them to the
ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r347903753
##########
File path:
flink-core/src/main/java/org/apache/flink/core/execution/DefaultExecutorServiceLoader.java
##########
@@ -48,7 +52,7 @@
public static final DefaultExecutorServiceLoader INSTANCE = new
DefaultExecutorServiceLoader();
@Override
- public ExecutorFactory getExecutorFactory(final Configuration
configuration) {
+ public ExecutorFactory getExecutorFactory(@Nonnull final Configuration
configuration) {
Review comment:
IIRC the community consensus is that all parameters are implicit non-null.
FYI our [code style
guide](https://flink.apache.org/contributing/code-style-and-quality-common.html#nullability-of-the-mutable-parts).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
