[
https://issues.apache.org/jira/browse/FLINK-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977639#comment-16977639
]
Chengjian edited comment on FLINK-14661 at 11/19/19 5:13 PM:
-------------------------------------------------------------
Hi [~phoenixjiangnan],
If no one is interested on this Jira, can i help to fix it as my first commit
to flink?
thanks.
was (Author: temper):
Hi [~phoenixjiangnan],
If no one is interested on this Jira, can i help to resolve it as my first
commit to flink?
thanks.
> rename args of setters in sql cli Environment
> ----------------------------------------------
>
> Key: FLINK-14661
> URL: https://issues.apache.org/jira/browse/FLINK-14661
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
> Affects Versions: 1.10.0
> Reporter: Bowen Li
> Priority: Major
> Labels: n00b
>
> Rename
> {code:java}
> public void setCatalogs(List<Map<String, Object>> catalogs) { ... }
> public void setTables(List<Map<String, Object>> tables) { ... }
> // functions
> {code}
> to
> {code:java}
> public void setCatalogs(List<Map<String, Object>> catalogMap) { ... }
> public void setTables(List<Map<String, Object>> tableMap) { ... }
> // functions
> {code}
> to avoid name conflicts with member variables.
> This is a newbie task for anyone new to the community to pick up and work on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
