bowenli86 commented on a change in pull request #10231: [FLINK-14711][table]
add alter and show function ddl
URL: https://github.com/apache/flink/pull/10231#discussion_r348085617
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterFunction.java
##########
@@ -52,21 +52,21 @@
private final boolean isSystemFunction;
- private final boolean hasTemporary;
+ private final boolean isTemporary;
public SqlAlterFunction(
- SqlParserPos pos,
- SqlIdentifier functionName,
- SqlCharStringLiteral functionClassName,
- String functionLanguage,
- boolean ifExists,
- boolean hasTemporary,
- boolean isSystemFunction) {
+ SqlParserPos pos,
+ SqlIdentifier functionName,
Review comment:
minor: rename to `functionIdentifier`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
