[ 
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu resolved FLINK-11935.
-----------------------------
    Fix Version/s: 1.10.0
       Resolution: Fixed

[FLINK-11935][table-planner-blink] Fix unixDateCeil in blink planner since 
CALCITE-3199 is not fixed in avatica-1.15.0
 - 1.10.0: f1a07ccefe22362718a97d5994553b6ba024a5b0

[FLINK-11935][table-planner-blink] Fix cast timestamp to string and vice-versa 
to avoid Gregorian cutover
 - 1.10.0: 827e45090dc34c8e6b381b16c4c4c1584aaeceea

[FLINK-11935][table-planner] Fix unixDateCeil in Flink since CALCITE-3199 is 
not fixed in avatica-1.15.0
 - 1.10.0: 26a9a4cecee64b55ec0f0bf0766e727d4668879c

[FLINK-11935][table-planner] Fix cast timestamp/date to string to avoid 
Gregorian cutover
 - 1.10.0: 25f87ec208a642283e995811d809632129ca289a

[FLINK-11935][table-planner][table-planner-blink] Remove DateTimeUtils from 
legacy planner and blink planner
 - 1.10.0: f868d3a7ccfbc62a234c5c22e0542ac2fc346c38


> Remove DateTimeUtils pull-in and fix datetime casting problem
> -------------------------------------------------------------
>
>                 Key: FLINK-11935
>                 URL: https://issues.apache.org/jira/browse/FLINK-11935
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: Rong Rong
>            Assignee: Zhenghua Gao
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This {{DateTimeUtils}} was pulled in in FLINK-7235.
> Originally the time operation was not correctly done via the {{ymdToJulian}} 
> function before the date {{1970-01-01}} thus we need the fix. similar to 
> addressing this problem:
> {code:java}
>  Optimized :1017-12-05 22:58:58.998 
>  Expected :1017-11-29 22:58:58.998
>  Actual :1017-12-05 22:58:58.998
> {code}
>  
> However, after pulling in avatica 1.13, I found out that the optimized plans 
> of the time operations are actually correct. it is in fact the casting part 
> that creates problem:
> For example, the following:
> *{{(plus(-12000.months, cast('2017-11-29 22:58:58.998', TIMESTAMP))}}*
> result in a StringTestExpression of:
> *{{CAST(1017-11-29 22:58:58.998):VARCHAR(65536) CHARACTER SET "UTF-16LE" 
> COLLATE "ISO-8859-1$en_US$primary" NOT NULL}}*
> but the testing results are:
> {code:java}
>  Optimized :1017-11-29 22:58:58.998
>  Expected :1017-11-29 22:58:58.998
>  Actual :1017-11-23 22:58:58.998
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to