[ 
https://issues.apache.org/jira/browse/FLINK-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978148#comment-16978148
 ] 

Jark Wu commented on FLINK-14716:
---------------------------------


[hotfix][FLINK-14716][table-planner-blink] Fix the order of fields projected 
into TableSource
 - 1.10.0: dde6b6263d8fd298c66b61853355719417c4e731

> Cooperate computed column with push down rules
> ----------------------------------------------
>
>                 Key: FLINK-14716
>                 URL: https://issues.apache.org/jira/browse/FLINK-14716
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: Jark Wu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In FLINK-14665, we supported computed column in planner. However, the 
> implementation of {{TableSourceTable#getRowType}} will include computed 
> columns which is possibly not right, because computed column is generated in 
> the downstream Project, not in the source scan. 
> This is possibly lead to errors when push project into source scan which will 
> call {{TableSourceTable#getRowType}} in the rule. Currently, all the tests 
> are passed because we don't have a test to cover this, i.e. computed column 
> on a projectable TableSource. We should at least add a test to cover this. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to