zhuzhurk commented on issue #10264: [FLINK-14811][runtime] Replace Java Streams 
in input check methods with for-loops
URL: https://github.com/apache/flink/pull/10264#issuecomment-555925209
 
 
   > Thanks for opening this @zhuzhurk ! The purpose sounds reasonable to me. 
Is there a benchmark report for this improvement?
   
   It's about 2x speed up if the job scale is large.  see [this 
discussion](https://issues.apache.org/jira/browse/FLINK-14735?focusedCommentId=16974209&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16974209).
   It's also suggested in the [flink code style 
guide](https://flink.apache.org/contributing/code-style-and-quality-java.html).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to