GJL commented on a change in pull request #10255: [FLINK-14859][runtime] Avoid 
leaking unassigned slots 
URL: https://github.com/apache/flink/pull/10255#discussion_r348443847
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
 ##########
 @@ -295,6 +295,21 @@ public void skipDeploymentIfVertexVersionOutdated() {
                assertThat(scheduler.requestJob().getState(), 
is(equalTo(JobStatus.RUNNING)));
        }
 
+       @Test
+       public void releaseSlotIfVertexVersionOutdated() {
 
 Review comment:
   That depends on the appender that is configured. log4j's `ConsoleAppender` 
writes to `System.err` and `System.out`. Both of which are instances of 
`PrintStream` which on my platform are initialized with `autoFlush=true`. If 
`autoFlush` is enabled, `PrintStream` flushes on newline. The bottom line is 
that it is not guaranteed to flush but it is likely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to