zhuzhurk commented on a change in pull request #10255: [FLINK-14859][runtime]
Avoid leaking unassigned slots
URL: https://github.com/apache/flink/pull/10255#discussion_r348490485
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
##########
@@ -295,6 +295,21 @@ public void skipDeploymentIfVertexVersionOutdated() {
assertThat(scheduler.requestJob().getState(),
is(equalTo(JobStatus.RUNNING)));
}
+ @Test
+ public void releaseSlotIfVertexVersionOutdated() {
Review comment:
Ok. There seems to be little risk then. We can keep it for now.
Thanks for the explanation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
