zentol commented on a change in pull request #10232: [FLINK-14314][runtime]
Allocate shared slot resources respecting the resources of all vertices in the
group
URL: https://github.com/apache/flink/pull/10232#discussion_r348467284
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SchedulerImpl.java
##########
@@ -385,7 +385,7 @@ private LogicalSlot completeAllocationByAssigningPayload(
if (coLocationConstraint.isAssigned()) {
// refine the preferred locations of the slot profile
- slotProfile = new SlotProfile(
+ slotProfile = SlotProfile.priorAllocation(
Review comment:
this is a really nice change ❤️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
