TisonKun commented on a change in pull request #10251: 
[FLINK-14851][FLINK-14850] Implement Executors and wire them to the 
ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r348858718
 
 

 ##########
 File path: 
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
 ##########
 @@ -144,17 +144,16 @@ protected ExecutionEnvironment() {
        }
 
        protected ExecutionEnvironment(final Configuration configuration) {
-               this(DefaultExecutorServiceLoader.INSTANCE, configuration);
+               this(DefaultExecutorServiceLoader.INSTANCE, configuration, 
null);
 
 Review comment:
   instead of `null`, shall we directly pass `getClass().getClassLoader()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to