dianfu commented on a change in pull request #10017: [FLINK-14019][python] add
support for managing environment and dependencies of Python UDF in Flink Python
API
URL: https://github.com/apache/flink/pull/10017#discussion_r348873473
##########
File path:
flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/AbstractPythonFunctionOperator.java
##########
@@ -225,7 +237,35 @@ public void processWatermark(Watermark mark) throws
Exception {
/**
* Creates the {@link PythonFunctionRunner} which is responsible for
Python user-defined function execution.
*/
- public abstract PythonFunctionRunner<IN> createPythonFunctionRunner();
+ public abstract PythonFunctionRunner<IN> createPythonFunctionRunner(
+ PythonEnvironmentManager pythonEnvironmentManager);
+
+ /**
+ * Returns the {@link PythonEnv} used to determine which
PythonEnvironmentManager will be created.
+ */
+ public abstract PythonEnv getPythonEnv();
+
+ private PythonEnvironmentManager createPythonEnvironmentManager(
Review comment:
Move the private method at the end of file then we can group all the private
methods together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
