zhuzhurk opened a new pull request #10275: [FLINK-14733][runtime] Introduce a 
builder for flexible ResourceProfile building
URL: https://github.com/apache/flink/pull/10275
 
 
   
   ## What is the purpose of the change
   
   The ResourceProfile constructors may accept values in raw types (double/int) 
or advanced types(CPUResource/MemorySize). Thus it had to maintain different 
kinds of constructors for the combinations. Or one may need to build advanced 
values types from raw types to use construct ResourceProfile.
   Using the constructor with many fields of the same types also makes it not 
clear to see what resource is set.
   
   This PR is to introduce a builder to enable flexible building of 
ResourceProfile. It allows setting a resource with advanced value types as well 
as raw value types.
   
   The change is based on #10232 to avoid conflicts.
   
   ## Brief change log
   
     - *Introduced ResourceProfile#Builder and related factory methods*
     - *Make ResourceProfile constructors to be private*
     - *Refactored usages of ResourceProfile constructors*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to