StephanEwen commented on a change in pull request #10278:
[FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL
input constraint for legacy scheduler
URL: https://github.com/apache/flink/pull/10278#discussion_r349059986
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1090,6 +1104,26 @@ else if (current == CANCELED || current == FAILED) {
}
}
+ private void finishPartitionsAndScheduleOrUpdateConsumers() {
+ final List<IntermediateResultPartition> newlyFinishedResults =
getVertex().finishAllBlockingPartitions();
+ if (newlyFinishedResults.isEmpty()) {
+ return;
+ }
+
+ final HashSet<ExecutionVertex> consumersToSchedule = new
HashSet<>();
Review comment:
Okay, sure, we can a set to just detect duplicates, and still schedule them
in order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
