dawidwys commented on a change in pull request #10223:
[FLINK-14787][configuration] Add configure method to StreamExecutionEnvironment
URL: https://github.com/apache/flink/pull/10223#discussion_r349120398
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java
##########
@@ -79,6 +80,28 @@ public DistributedCacheEntry(String filePath, Boolean
isExecutable, byte[] blobK
this(filePath, isExecutable, blobKey, false);
}
+ @Override
Review comment:
That's not mandatory. I could've implemented it in tests in an asserter. I
think it does not harm to have a proper `equals/hashcode`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
