[
https://issues.apache.org/jira/browse/FLINK-14818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979338#comment-16979338
]
Piotr Nowojski commented on FLINK-14818:
----------------------------------------
I'm not sure. It depends how complicated the mock would be? If it's overriding
one simple method, then it's probably fine. If we have to mock hundreds lines
of code, maybe it's not worth? Or at least not for now?
> StreamNetworkBenchmarkEnvironment incorrectly setups a receiving InputGate
> --------------------------------------------------------------------------
>
> Key: FLINK-14818
> URL: https://issues.apache.org/jira/browse/FLINK-14818
> Project: Flink
> Issue Type: Bug
> Components: Benchmarks
> Affects Versions: 1.7.2, 1.8.2, 1.9.1
> Reporter: Piotr Nowojski
> Assignee: Yingjie Cao
> Priority: Major
>
> In network benchmark (for example 1000 channels benchmark with 4 record
> writers) {{StreamNetworkBenchmarkEnvironment#createInputGate}} creates 1000
> input gates with 4 input channels each, which doesn't make much sense. I
> would expect either having 4 receivers with single input gate with 1000
> channels each, or a single receiver with 4 input gates, with 1000 channels
> each.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
