Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1266#issuecomment-152544715
  
    Looks good to me. Is there maybe a way to also make `readRecord()` common 
to tuples and POJOs, because there we duplicate all the code and only the call 
that creates the tuple or POJO (or fills it) is different, if I'm not mistaken.
    
    Thanks for the work you're putting in there, I know it's not glorious but 
some parts need cleanup/refactoring. :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to