docete commented on a change in pull request #10268: 
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink 
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349446907
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
 ##########
 @@ -644,10 +644,13 @@ public SqlMonotonicity 
getMonotonicity(SqlOperatorBinding call) {
                OperandTypes.family(SqlTypeFamily.STRING, 
SqlTypeFamily.INTEGER),
                SqlFunctionCategory.STRING);
 
+       // TODO: the return type of TO_TIMESTAMP should be TIMESTAMP(9)
 
 Review comment:
   FLINK-14645 would fix the de/serializing style in DescriptorProperties 
put/getTableschema and skip the conversion from DataType to TypeInformation(and 
back),which also fix the to_timestamp in DDL case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to