JingsongLi commented on a change in pull request #10268:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349461114
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/match/RowtimeProcessFunction.java
##########
@@ -44,7 +44,7 @@ public RowtimeProcessFunction(int rowtimeIdx,
TypeInformation<BaseRow> returnTyp
@Override
public void processElement(BaseRow value, Context ctx,
Collector<BaseRow> out) throws Exception {
- long timestamp = value.getLong(rowtimeIdx);
+ long timestamp = value.getTimestamp(rowtimeIdx,
3).getMillisecond();
Review comment:
Looks like it is very easy to pass the precision.
So I would suggest like Jark, just pass it to avoid more hardcode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
