docete commented on a change in pull request #10268:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349479325
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/functions/utils/UserDefinedFunctionUtils.scala
##########
@@ -728,10 +727,12 @@ object UserDefinedFunctionUtils {
expected.isPrimitive && Primitives.wrap(expected) == candidate ||
candidate == classOf[Date] && (expected == classOf[Int] || expected ==
classOf[JInt]) ||
candidate == classOf[Time] && (expected == classOf[Int] || expected ==
classOf[JInt]) ||
- candidate == classOf[Timestamp] && (expected == classOf[Long] ||
- expected == classOf[JLong]) ||
Review comment:
Decide to disable this in the offline discussing @KurtYoung @JingsongLi
IMO Follow the comments in TimestampType is better. And if we want let UDX
with long accept TIMESTAMP, we should add the conversion class to TimestampType.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
