leonardBang commented on a change in pull request #10289: [FLINK-14924][table
sql / api] CsvTableSource can not config empty column as null
URL: https://github.com/apache/flink/pull/10289#discussion_r349507459
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/CsvTableSource.java
##########
@@ -129,8 +163,43 @@ public CsvTableSource(
boolean ignoreFirstLine,
String ignoreComments,
boolean lenient) {
- this(new CsvInputFormatConfig(path, fieldNames, fieldTypes,
selectedFields,
- fieldDelim, lineDelim, quoteCharacter, ignoreFirstLine,
ignoreComments, lenient));
+ this(path, fieldNames, fieldTypes, selectedFields,
+ fieldDelim, lineDelim, quoteCharacter, ignoreFirstLine,
+ ignoreComments, lenient, false);
+ }
+
+ /**
+ * A {@link InputFormatTableSource} and {@link LookupableTableSource}
for simple CSV files with
+ * a (logically) unlimited number of fields.
+ *
+ * @param path The path to the CSV file.
+ * @param fieldNames The names of the table fields.
+ * @param fieldTypes The types of the table fields.
+ * @param selectedFields The fields which will be read and
returned by the table source. If
+ * None, all fields are returned.
+ * @param fieldDelim The field delimiter, "," by default.
+ * @param lineDelim The row delimiter, "\n" by default.
+ * @param quoteCharacter An optional quote character for String
values, null by default.
+ * @param ignoreFirstLine Flag to ignore the first line, false by
default.
+ * @param ignoreComments An optional prefix to indicate
comments, null by default.
+ * @param lenient Flag to skip records with parse error
instead to fail, false by
+ * default.
+ * @param emptyColumnAsNull Flag to treat empty column as null.
+ */
+ public CsvTableSource(
+ String path,
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
