RustedBones commented on issue #10285: [FLINK-14896] [flink-kinesis-connector] Set jackson and guava dependency to flink-shaded URL: https://github.com/apache/flink/pull/10285#issuecomment-557526924 Ok sorry. The following confused me. > instead of each individual module shading the dependency Looking in the code, `flink-shaded` is indeed only used for direct usage. All connector that depend transitively on `jackson` are shading it to avoid conflict with other libs. eg `flink-s3-fs-base`: ```xml <relocation> <pattern>com.fasterxml</pattern> <shadedPattern>org.apache.flink.fs.s3base.shaded.com.fasterxml</shadedPattern> </relocation> ``` Should the `flink-kinesis-connector` do the same instead of excluding the package?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
