JingsongLi commented on issue #10059: [FLINK-14543][table] Support partition 
for temporary table
URL: https://github.com/apache/flink/pull/10059#issuecomment-557855753
 
 
   > Hi @JingsongLi sorry for a delayed response and thank you for the update.
   > 
   > I might be wrong, but I think there are still some bits missing. How are 
the partitions passed to the `TableSource/SinkFactory` if the table was 
registered wtih `registerTableSource`? Do we want to support that?
   
   Hi, @dawidwys , we don't want to support that.
   `registerTableSource` and `registerTableSink` are deprecated, the 
recommended way is `connect` to create temporary table.
   We have added the interface of `getPartitionKeys` on 
`PartitionedTableSource`, but we found that there are some problems, and it is 
duplicate to `CatalogTable`.
   And like `TableSchema`, we don't think `getPartitionKeys` should be exposed 
from the source's interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to