carp84 commented on issue #10300: [FLINK-14926] [state backends] Make sure no resource leak of RocksObject URL: https://github.com/apache/flink/pull/10300#issuecomment-557891430 Making enum implementing `AutoCloseable` is a little bit anti-pattern since normally an `AutoCloseable` is stateful, as already reflected in `PredefineOptions.SPINNING_DISK_OPTIMIZED_HIGH_MEM`. On the other hand, changing `PredefinedOptions` from enum to class may require a bigger change, so I'm hesitating to fix it now or mark it as a TODO.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
