dawidwys commented on a change in pull request #10307: [FLINK-14903][table]
Relax structured types constraints
URL: https://github.com/apache/flink/pull/10307#discussion_r350047423
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeParser.java
##########
@@ -557,10 +558,18 @@ private LogicalType parseTypeByIdentifier() {
nextToken(TokenType.IDENTIFIER);
parts.add(tokenAsString());
}
- return new UnresolvedUserDefinedType(
- lastPart(parts, 2),
- lastPart(parts, 1),
- lastPart(parts, 0));
+ final String catPart = lastPart(parts, 2);
Review comment:
I think this logic is duplicated in `UnresolvedIdentifier.of`. We could
create the `UnresolvedIdentifier` as `UnresolvedIdentifier.of(parts.toArray())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
