TisonKun opened a new pull request #10311: [FLINK-14762][client] Enrich JobClient API URL: https://github.com/apache/flink/pull/10311 ## What is the purpose of the change This pull request is a rebase on master of #10185 . We generally enrich `JobClient` API as described in FLIP-74 as well as let `ClusterClient#submitJob` returns a `CompletableFuture` of `JobClient`. For now I think we may or may not introduce dedicated tests because the only implementation is a thin wrapper of `ClusterClient`. Maybe we can defer the test set until other implementation comes because testing a wrapper gains us little. Another tricky thing is about lifecycle management a.k.a. whether or not close `ClusterClient` on `ClusterClientJobClientAdapter` closed. Currently I use a boolean parameter `moveOwnship` for explicitly setting, but still looking for other solution. ## Verifying this change This change is already covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (yes, it enriches `JobClient` which is to be public API). - If yes, how is the feature documented? (JavaDocs) cc @aljoscha @kl0u
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
