rkhachatryan commented on a change in pull request #10151: [FLINK-14231] Handle
the processing-time timers before closing operator to properly support endInput
URL: https://github.com/apache/flink/pull/10151#discussion_r350103943
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -431,13 +439,8 @@ public final void invoke() throws Exception {
// make sure no further checkpoint and notification
actions happen.
// we make sure that no other thread is currently in
the locked scope before
- // we close the operators by trying to acquire the
checkpoint scope lock
- // we also need to make sure that no triggers fire
concurrently with the close logic
// at the same time, this makes sure that during any
"regular" exit where still
synchronized (lock) {
- // this is part of the main logic, so if this
fails, the task is considered failed
- closeAllOperators();
-
Review comment:
Looks like now we don't close operators in a case when mailbox processor
stopped for reason other than END_OF_INPUT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
