lirui-apache commented on a change in pull request #10296:
[FLINK-14691][table]Add use/create/drop/alter database operation and support it
in flink/blink planner
URL: https://github.com/apache/flink/pull/10296#discussion_r350159832
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
##########
@@ -455,6 +457,94 @@ public void createTable(CatalogBaseTable table,
ObjectIdentifier objectIdentifie
"CreateTable");
}
+ /**
+ * Creates a database in a given fully qualified path.
+ * @param catalogName
+ * @param databaseName
+ * @param database
+ * @param ignoreIfExists If false exception will be thrown if a
database exists in the given path.
+ */
+ public void createDatabase(String catalogName,
+ String databaseName,
+ CatalogDatabase database,
+ boolean ignoreIfExists,
+ boolean ignoreNoCatalog) {
Review comment:
If a user tries to create a table in a non-existing DB, we don't ignore the
"no DB" exception. So I'm not sure why we want to ignore "no catalog" exception
here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
