bowenli86 commented on a change in pull request #10296: [FLINK-14691][table]Add
use/create/drop/alter database operation and support it in flink/blink planner
URL: https://github.com/apache/flink/pull/10296#discussion_r350377502
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -301,10 +301,16 @@ public boolean databaseExists(String databaseName)
throws CatalogException {
}
@Override
- public void dropDatabase(String name, boolean ignoreIfNotExists) throws
DatabaseNotExistException,
- DatabaseNotEmptyException, CatalogException {
+ public void dropDatabase(String name, boolean ignoreIfNotExists)
+ throws DatabaseNotExistException,
DatabaseNotEmptyException, CatalogException {
+ dropDatabase(name, ignoreIfNotExists, true);
+ }
+
+ @Override
+ public void dropDatabase(String name, boolean ignoreIfNotExists,
boolean isRestrict)
Review comment:
rename the param to `restrict`? to be consistent with param `cascade` in the
`public void dropDatabase(String name, boolean deleteData, boolean
ignoreIfNotExists, boolean cascade)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
