aljoscha commented on a change in pull request #10313: [FLINK-14840] Use
Executor interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r350717396
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -523,12 +525,12 @@ public void stop(SessionContext session) {
}
// store the result with a unique id (the job id for now)
- final String resultId = jobGraph.getJobID().toString();
Review comment:
It used to be that it was the `JobID` of the actual job. But that's not
possible anymore because a `Pipeline` doesn't have a `JobID` anymore because we
only generate the `JobGraph` when handing the `Pipeline` to the `Executor`.
Still using a `JobId` here is a bit weird, I'm pushing a commit that uses
`UUID` instead. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
