GJL commented on a change in pull request #10256: [FLINK-14467][runtime] Let
MesosJobClusterEntrypoint use user code class loader
URL: https://github.com/apache/flink/pull/10256#discussion_r350703211
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
##########
@@ -43,13 +43,14 @@
* possible to bypass this overlay and rely on the normal installation method.
*
* <p>The following files are copied to the container:
- * - flink/bin/
- * - flink/conf/
- * - flink/lib/
+ * - bin/
+ * - conf/
+ * - lib/
+ * - plugins/
*/
public class FlinkDistributionOverlay extends AbstractContainerOverlay {
- static final Path TARGET_ROOT = new Path("flink");
+ static final File TARGET_ROOT = new File(Path.CUR_DIR);
Review comment:
I see. This may be considered a bug in the `Path` class. Since it is not
obvious that `Path` cannot be used, can work around that by:
```
private static final String TARGET_ROOT_STR = Path.CUR_DIR;
static final Path TARGET_ROOT = new Path(TARGET_ROOT_STR);
```
```
container.getEnvironmentVariables().put(ENV_FLINK_HOME_DIR, TARGET_ROOT_STR);
```
Moreover, shouldn't there be a unit test in `FlinkDistributionOverlayTest`
asserting that the environment variable is correctly set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
