GJL commented on a change in pull request #10309: [FLINK-14909][runtime] Let
tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r350739902
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -152,6 +156,11 @@ public DefaultScheduler(
restartBackoffTimeStrategy);
this.schedulingStrategy =
schedulingStrategyFactory.createInstance(this, getSchedulingTopology());
this.executionSlotAllocator =
checkNotNull(executionSlotAllocatorFactory).createInstance(getInputsLocationsRetriever());
+
+ this.executionVertexIDComparator = new
ExecutionVertexIDComparator(
Review comment:
Note that it's also generally considered bad practice to call non-final
methods in the constructor [1]
[1]
https://lustforge.com/2014/02/08/dont-call-non-final-methods-from-your-constructor-please/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
