GJL commented on a change in pull request #10309: [FLINK-14909][runtime] Let
tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r350776372
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/LazyFromSourcesSchedulingStrategyTest.java
##########
@@ -377,4 +377,16 @@ private LazyFromSourcesSchedulingStrategy
startScheduling(TestingSchedulingTopol
schedulingStrategy.startScheduling();
return schedulingStrategy;
}
+
+ private static List<ExecutionVertexID> mapExecutionVerticesToIDs(
+ final List<TestingSchedulingExecutionVertex> vertices) {
+
+ return
vertices.stream().map(TestingSchedulingExecutionVertex::getId).collect(Collectors.toList());
+ }
+
+ private static List<ExecutionVertexID> mapDeploymentOptionsToIDs(
Review comment:
If you want to stick with `assertEquals`, I am fine with that. However, I
would add a method to `TestingSchedulerOperations` that directly returns the
execution vertex ids to avoid having `mapDeploymentOptionsToIDs()` calls
everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
