JingsongLi commented on a change in pull request #10322: [hotfix] Improve error 
message in JDBCUpsertTableSink
URL: https://github.com/apache/flink/pull/10322#discussion_r351117657
 
 

 ##########
 File path: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsertTableSink.java
 ##########
 @@ -69,7 +69,8 @@ private JDBCUpsertTableSink(
 
        private JDBCUpsertOutputFormat newFormat() {
                if (!isAppendOnly && (keyFields == null || keyFields.length == 
0)) {
-                       throw new 
UnsupportedOperationException("JDBCUpsertTableSink can not support ");
+                       throw new 
UnsupportedOperationException("JDBCUpsertTableSink doesn't support append mode 
or upsert " +
 
 Review comment:
   Hi @link3280 , `JDBCUpsertTableSink` can support append mode. It just not 
support upsert mode without keys.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to