zhuzhurk commented on a change in pull request #10309: [FLINK-14909][runtime]
Let tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r351149505
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingStrategy.java
##########
@@ -40,9 +40,9 @@
/**
* Called whenever vertices need to be restarted (due to task failure).
*
- * @param verticesToRestart The tasks need to be restarted
+ * @param verticesToRestart The tasks to be restarted, topologically
sorted
*/
- void restartTasks(Set<ExecutionVertexID> verticesToRestart);
+ void restartTasks(List<ExecutionVertexID> verticesToRestart);
Review comment:
This PR is now made in another way, which significantly reduced the changes
especially on production codes.
The basic idea is that in `DefaultScheduler` we do not sort the vertices
anymore but respect the order given by the scheduling strategy.
The scheduling strategy is now responsible for ordering the vertices to
schedule if it feels like to. This should be an easy work thought since it can
get to know the topological order from the `SchedulingTopology`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
