GJL commented on a change in pull request #10235: [FLINK-14839][config] Let 
JobGraph#classpaths become non-null
URL: https://github.com/apache/flink/pull/10235#discussion_r351205882
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
 ##########
 @@ -100,7 +101,7 @@
        private final List<PermanentBlobKey> userJarBlobKeys = new 
ArrayList<>();
 
        /** List of classpaths required to run this job. */
-       private List<URL> classpaths = Collections.emptyList();
 
 Review comment:
   It's problematic that `JobGraph` implements `Serialized` and `classpaths` is 
a non-transient field. After a cluster upgrade to 1.10 `addClasspaths` will 
throw `UnsupportedOperationException` if `classpath` of the serialized JobGraph 
was previously empty. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to