aljoscha commented on issue #9711: [FLINK-14033] upload user artifacts for yarn 
job cluster
URL: https://github.com/apache/flink/pull/9711#issuecomment-559035246
 
 
   Thanks for this contribution, I think it is a valuable feature! Could you 
please rebase this on top of the latest master and clean up the commits? I 
noticed some dangling/unused changes, for example you add a 
`CacheBasedDataSource` that is not used, and in `YarnTestCacheJob` the mapper 
that does the actual testing is not used, meaning the test does not test what 
it is supposed to test.
   
   Did you think about how the uploaded files are being cleaned up? What is the 
lifecycle? Will they stay in the DFS after the application finishes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to