zentol commented on a change in pull request #10285: [FLINK-14896]
[flink-kinesis-connector] Set jackson and guava dependency to flink-shaded
URL: https://github.com/apache/flink/pull/10285#discussion_r351227537
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -193,25 +193,30 @@ under the License.
<artifactSet
combine.children="append">
<includes>
<include>com.amazonaws:*</include>
+
<include>com.fasterxml:*</include>
<include>com.google.protobuf:*</include>
<include>org.apache.httpcomponents:*</include>
<!--
Java 11 specific inclusion; should be a no-op for other versions -->
<include>javax.xml.bind:jaxb-api</include>
</includes>
</artifactSet>
<relocations
combine.children="override">
- <!-- DO NOT
RELOCATE GUAVA IN THIS PACKAGE -->
<relocation>
-
<pattern>com.google.protobuf</pattern>
-
<shadedPattern>org.apache.flink.kinesis.shaded.com.google.protobuf</shadedPattern>
+
<pattern>com.amazonaws</pattern>
+
<shadedPattern>org.apache.flink.streaming.kinesis.shaded.com.amazonaws</shadedPattern>
</relocation>
<relocation>
-
<pattern>com.amazonaws</pattern>
-
<shadedPattern>org.apache.flink.kinesis.shaded.com.amazonaws</shadedPattern>
+
<pattern>com.fasterxml</pattern>
+
<shadedPattern>org.apache.flink.streaming.kinesis.shaded.com.fasterxml</shadedPattern>
+ </relocation>
+ <!-- DO NOT
RELOCATE GUAVA IN THIS PACKAGE -->
Review comment:
Not sure; it's not justified in the commit, PR or JIRA.
Without further research my guess would be that guava is exposed in one of
the Kinesis APIs, and we wanted to ensure that users don't try to use a
different guava version. (If it were shaded it wouldn't show up in the pom, and
working against relocated namespaces i kind of a pain). But this is purely an
optimistic guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
