dmvk commented on issue #10153: [FLINK-14709] Allow outputting elements in user defined close method,… URL: https://github.com/apache/flink/pull/10153#issuecomment-559088108 @aljoscha thanks for comments! :+1: for moving emission of final batch to `closeTask` method. `ChainedDriver` is a `Collector` (which is closable). When we `close` the head collector, all chained collectors get closed in a proper order and therefore we can emit more elements. If we use `close` only for resource cleanup only, we can avoid code duplication in `cancelTask` (which need to perform resource cleanup as well), if we make sure to call `close` after both `closeTask` and `cancelTask` methods. If we decide to do this, I think it should be done in separate JIRA / PR. WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
