aljoscha commented on issue #10153: [FLINK-14709] Allow outputting elements in user defined close method,… URL: https://github.com/apache/flink/pull/10153#issuecomment-559098488 The reason I asked is because you did move the resource cleanup already so I thought we could do everything in one go, but you might be right. Another thing: why does `close()` call `dispose(true)` while `cancelTask()` calls `dispose(false)`. This changes the behaviour of `cancelTask()` which ignored exceptions before. It seems to me that it should be the other way round, maybe?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
