mchro commented on a change in pull request #10339: [FLINK-14976][cassandra] 
Release semaphore on all Throwable's in send()
URL: https://github.com/apache/flink/pull/10339#discussion_r351337414
 
 

 ##########
 File path: 
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
 ##########
 @@ -361,6 +381,12 @@ private TestCassandraSink 
createOpenedSendExceptionTestCassandraSink(CassandraSi
                return testCassandraSink;
        }
 
+       private TestCassandraSink 
createOpenedSendErrorTestCassandraSink(CassandraSinkBaseConfig config) {
 
 Review comment:
   Done; for consistency I also made the ExceptionSink static.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to