Wosin edited a comment on issue #8371: [FLINK-9679] - Add AvroSerializationSchema URL: https://github.com/apache/flink/pull/8371#issuecomment-559151254 Hey @aljoscha, I have some issues with Travis, but I will try to fix the rest of the checkstyle issues today:) As for the schema coder I will take a look at this and try to fix that too. As for the difference between those classes, technically we could make `SchemaCoder` return the `byte[]` instead of `int` and append it to the serialized message. I haven't thought of that before tbh. The difference comes from the fact that in Confluent the messages are prepended with `0` and byte encoded id of the schema, which is specific to this format only. But, as I said, technically we could push it to `SchemaCoder` to encode the prefix and then return it from `writeSchema` method and prepend message with this value.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
