wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r351782380
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -574,12 +559,10 @@ static ContainerLaunchContext createTaskExecutorContext(
}
// prepare additional files to be shipped
- for (String shipResourceDescStr : shipListString.split(",")) {
+ for (String shipResourceDescStr : shipListString.split(";")) {
Review comment:
I think the `ENV_CLIENT_SHIP_FILES` is an internal environment. The users
could not set the ship files via `system.env()`. The only way to set ship files
is using `-yt`. And the separator of `-yt` is same as before.
If you insist, i will change `;` to `,`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
