[
https://issues.apache.org/jira/browse/FLINK-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984419#comment-16984419
]
Andrey Zagrebin commented on FLINK-14566:
-----------------------------------------
It sounds to me like 2 different ways to set resource spec in general:
# absolute requirements: this is known ResourceSpec which we have now
# weighted requirements: another type of ResourceSpec where each dimension has
a relative weight then current UNKNOWN is just everything with weight 1 for all
operators similar to what [~xintongsong] suggests and can be implicitly the
default spec. Not sure how we can implement this by adding it to
{{Transformation}}/{{StreamNode}}. I would prefer just setting another type of
spec.
I would not again allow to mix those types of specs in the job atm to avoid
complexity.
But true, the described approach requires a bit bigger effort than just
adjusting current ResourceSpec with boolean flags, I would still try to go in
this direction.
> Enable ResourceSpec to get/set whether managed memory is used
> -------------------------------------------------------------
>
> Key: FLINK-14566
> URL: https://issues.apache.org/jira/browse/FLINK-14566
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
> Affects Versions: 1.10.0
> Reporter: Zhu Zhu
> Priority: Minor
> Fix For: 1.10.0
>
>
> To calculate managed memory fraction for an operator with UNKNOWN resources,
> we need to know whether the operator will use managed memory, according to
> FLINK-14062.
> I'd propose to define special values of
> onHeapManagedMemory/offHeapManagedMemory
> in ResourceSpec(introduced in FLINK-14405) to distinguish whether managed
> memory is used.
> - For UNKNOWN resource spec, onHeapManagedMemory==MemorySize.ZERO means on
> heap managed memory is used, while onHeapManagedMemory==null means not. For
> non-UNKNOWN resource spec, managed memory size larger than zero indicates it
> is used.
> - similar for off heap managed memory.
> getters: isUsingManagedMemoryOnHeap()/isUsingManagedMemoryOffHeap()
> setters:
> setUsingManagedMemoryOnHeap(boolean)/setUsingManagedMemoryOffHeap(boolean)
> (setters are only allowed to invoke on UNKNOWN, should be ignored for
> non-UNKNOWN for compatibility)
> {{ResourceSpec#isKnown()}} should be added to replace existing UNKNOWN usages
> for equality checking.
> cc [~ykt836] [~trohrmann] [~azagrebin] [~xintongsong]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
