pnowojski commented on issue #10247: [FLINK-14813][runtime]Expose the new 
mechanism implemented in FLINK-1…
URL: https://github.com/apache/flink/pull/10247#issuecomment-559724869
 
 
   I'm not sure if we need to create a separate `BackPressureMetricGroup`, we 
could, but it might be not worth it, as I can not envision having more than two 
metrics in it `isBackPressured` and `isBackPressuring`.  
   
   One more thing is that in the future, we could hook up `isBackPressured` 
status/metric with the data sink status. Which means that `isBackPressured` is 
not just shuffle service concept, but one level up. So I would put the 
`isBackPressured` metric either directly inside existing `TaskIOMetricGroup`, 
or in `TaskIOMetricGroup.BackPressureGroup`. This would also mean that the 
documentation would have to be adjust and the `isBackPressured` metric should 
move from a separate table to the `IO` 
[table](https://ci.apache.org/projects/flink/flink-docs-stable/monitoring/metrics.html#io).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to