azagrebin commented on a change in pull request #10339:
[FLINK-14976][cassandra] Release semaphore on all Throwable's in send()
URL: https://github.com/apache/flink/pull/10339#discussion_r352132926
##########
File path:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
##########
@@ -296,6 +296,26 @@ public void testReleaseOnSendException() throws Exception
{
}
}
+ @Test(timeout = DEFAULT_TEST_TIMEOUT)
+ public void testReleaseOnSendError() throws Exception {
Review comment:
ok, thanks, looks good
There is one more commit which actually resolves Throwable checking problem
completely:
https://github.com/azagrebin/flink/commit/6f200a33538cfdfd0dbc8fd597d057cfa298f959
Could you also check it and squash into the PR if it is ok? Then I will
merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
