TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352214874
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -155,6 +156,10 @@
private String zookeeperNamespace;
+ // Pre-uploaded flink files, key is relative path(for example,
lib/flink-dist_{version}.jar),
+ // and value is remote file status.
+ private final Map<String, FileStatus> preUploadedFlinkFiles;
Review comment:
nit: follow the other configs pattern, i.e., init a empty map and call
`addAll` when deploy instead of initializing in constructor. It can be a
follow-up we generally refactor deployment inside YarnClusterDescriptor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
