tweise commented on a change in pull request #10346: [FLINK-14972] Make
Remote(Stream)Environment use Executors.
URL: https://github.com/apache/flink/pull/10346#discussion_r352313962
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/RemoteStreamExecutionEnvironmentTest.java
##########
@@ -108,7 +120,46 @@ public void testRemoteExecutionWithSavepoint() throws
Exception {
when(mockedClient.submitJob(any())).thenReturn(CompletableFuture.completedFuture(jobID));
when(mockedClient.requestJobResult(eq(jobID))).thenReturn(CompletableFuture.completedFuture(jobResult));
+ RemoteStreamEnvironment env = new RemoteStreamEnvironment(
+ new TestExecutorServiceLoader(jobID,
mockedClient),
+ "fakeHost",
+ 1,
+ null,
+ new String[]{},
+ null,
+ restoreSettings);
Review comment:
This should check if the restoreSettings were actually applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
