klion26 commented on a change in pull request #10344:
[FLINK-14264][StateBackend][Rest] Expose state backend in checkpoint rest api
URL: https://github.com/apache/flink/pull/10344#discussion_r352404077
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/CheckpointCoordinatorConfiguration.java
##########
@@ -36,6 +38,8 @@
private static final long serialVersionUID = 2L;
+ private String stateBackendName;
Review comment:
I think it's the name here that makes people confused. the
`stateBackendName` here is `checkpoint backend name`, such as
`MemoryStateBackend`, `FsStateBackend` or `RocksDBStateBackend`, and I think
they'are relevant with `CheckpointCoordinator`, we'll also pass the backend
into
[CheckpointCoordinator](https://github.com/apache/flink/blob/8c6cc4505a4c27daadb00cd94df8a7e955eb8d52/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L231)
to init the checkpoint directory.
Maybe we could update the name here, what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
