wuchong commented on a change in pull request #10268:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r352403751
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlDateTimeUtils.java
##########
@@ -114,6 +123,18 @@ public SimpleDateFormat getNewInstance(String key) {
}
};
+ /**
+ * A ThreadLocal cache map for DateTimeFormatter.
+ * (string_format) => formatter
+ */
+ private static final ThreadLocalCache<String, DateTimeFormatter>
DateTimeFormatter_CACHE =
Review comment:
nit: Use full upper case for static final variable
`DATETIME_FORMATTER_CACHE`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
